-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/seed richer badges #162
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c6512ea
to
1f12a4c
Compare
Wiping the database is: - slow. It adds over a minute to the boot process of a docker compose up - cumbersome. We start with a blank slate after every boot, which means issued badges, accounts, logins, etc all are gone. Ideally the blank state is useful in itself, but it's lacking data and setup currently. So after booting we need quite a few manual tasks each time, to get relevant badges into users' backpack. This feature was commented out in the commit: commit 2916276 Author: Okke Harsta <[email protected]> Date: Wed Aug 18 14:24:39 2021 +0200 Temporary comment to fix deployment Δ apps/mainsite/management/commands/seed.py But, as "temporary fixes" tend to do, it remained in, and now causes work and delays when developing. We also add a persistent volume to docker-compose so that the data for the mysql database is stored outside of the container and can live across container lifecycles.
All BadgeClasses in Medicine get alignment-items: - EQF - ECTS
This user is often used in demo's and in tests.
Currenly, failing seeds would be "eaten" by the try/except clauses, and a calling script, e.g. the entrypoint.sh would think a seed was performed successfully (no errors, exit code 0) and continue. But that would start a server that does not have required data. This change ensures errors are propagated to the caller of the script and exit code is nonzero if a seed fails. WIP, because we need to consider potential issues for production and deployments that this might cause. If any.
Also present in 0ab582f, but that hasn't been merged yet.
…ment Instead, pick the first, and if none exist, crash.
We fix this by explicitly setting an ID, and by allowing multiple accounts with the demo emailaddress to exist. We then pick the first.
0eb0650
to
4367561
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some extra and richer data to the seeded badges.
So that local development has some more data and attributes to use out of the box.
It improves:
badge_class_description
to make it more structured and readable.criteria_text
to provide a clearer description of the requirements for earning the badge.It adds:
quality_assurance_description
,quality_assurance_name
, andquality_assurance_url
attributes for half of the badge classes to include quality assurance information.assessment_type
attribute to half of the badge classes, with predefined types such as "testing" and "application of a skill".assessment_supervised
toTrue
for half of the badge classes withassessment_type
set to "testing".identity_checked
toTrue
for half of the badge classes that haveassessment_supervised
set toTrue
.